if statement doesn't work as it should!!!

[JAlizadeh]

Does anyone understand what is wrong here?  For UIButton Blue Background, if statement doesn't work.  For UIButton Green Background, it works fine.  Everything else works properly.  Thanks,

#define normalButton [UIImage imageNamed:@"blueCategoryBackgroundImage.png"]
#define selectedButton [UIImage imageNamed:@"greenCategoryBackgroundImage.png"]

//When General Button is clicked, UIButton Background changes to Blue Background or Green Background based on previous selection
-(IBAction) generalButtonClicked
{   
    //Setup logic for Background Image
    if (generalButton.currentBackgroundImage != nil)
    {
        if ([generalButton.currentBackgroundImage isEqual: normalButton])
       {
            [generalButton setBackgroundImage: selectedButton forState:UIControlStateNormal];
        }
        else
        {
            [generalButton setBackgroundImage: normalButton forState:UIControlStateNormal];
        }
       
    }
    else
    {
        NSLog(@"There is a problem with current Background Image.");
    }
   
    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
       
    //remove existing saved image
    if ([userDefaults dataForKey:@"imageGeneral"] != nil)
    {
        [userDefaults removeObjectForKey: @"imageGeneral"];
    }
   
    //Save New Background Image
    NSData *imageGeneralData = UIImagePNGRepresentation(generalButton.currentBackgroundImage);
    [userDefaults setObject:imageGeneralData forKey:@"imageGeneral"];
    [userDefaults synchronize];
}

- (void)viewDidLoad
{
    [super viewDidLoad];
    // Do any additional setup after loading the view from its nib.
     
    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
   
//retrieve imageGeneral
    if ([userDefaults dataForKey:@"imageGeneral"] != nil)
    {
        NSData *imgGeneralData = [userDefaults dataForKey:@"imageGeneral"];
        UIImage *imgGeneral = [UIImage imageWithData:imgGeneralData];
        [generalButton setBackgroundImage:imgGeneral forState:UIControlStateNormal];
    }
    else
    {
        NSLog(@"There is a problem with imageGeneral Retrieval.");
    }

    [userDefaults synchronize];
}

[skochan]

Each time you execute the imageNamed: method through either normalButton or selectedButton you are creating a new instance from the UIImage class, and thus a different reference to a different object.  They'll never match.  Once you fix that, you can just use the normal == operator to test if the two objects are identical.

Cheers,

Steve

[JAlizadeh]

Thanks Steve,  I think you are saying to not create new object with normalButton below.

        if ([generalButton.currentBackgroundImage isEqual: normalButton])

I created UIButton with IB.  Also, I set the Background image with that too.  I need to figure out how to using existing object based on that setup.  I'll continue to study it.

Thanks,

[skochan]

You can also keep an instance variable that tracks the image on the button (or use the button's tag property if you want).

Cheers,

Steve

[JAlizadeh]

Using Button's Tag seems to be the easiest way to go.  Thanks for your guidance.